sse: add closed SelectCase to handle request closing signal#25
Open
sse: add closed SelectCase to handle request closing signal#25
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new "closed" select case to the Server-Sent Events (SSE) connection handler to properly manage request closure signals. Key changes include:
- Adding a new test case for handling connection closure in sse_test.go.
- Updating the Bind function and connection.handle method in sse.go to process a cancellation signal.
- Extending the select cases in connection.handle to include a closed case that returns immediately.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sse_test.go | New test added to simulate and verify behavior on connection close. |
| sse.go | Modified Bind and connection.handle to include closed signal handling. |
Comments suppressed due to low confidence (1)
sse_test.go:162
- [nitpick] Instead of using a fixed sleep duration to wait for potential events after the connection is closed, consider using synchronization primitives (such as a WaitGroup or channel notifications) to deterministically verify that no events are delivered.
time.Sleep(3 * time.Second)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
A clear and concise description of what the pull request is about, i.e. what problem should be fixed?
Link to the issue: flamego/flamego#187
Checklist